Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 support #1891

Merged
merged 5 commits into from
Apr 12, 2024
Merged

Add Python 3.12 support #1891

merged 5 commits into from
Apr 12, 2024

Conversation

fealho
Copy link
Member

@fealho fealho commented Apr 4, 2024

CU-86ayu6zrx, Resolve #1704.

@sdv-team
Copy link
Contributor

sdv-team commented Apr 4, 2024

@fealho fealho force-pushed the issue-1704-py12 branch from 94d4e36 to 42b044a Compare April 9, 2024 19:07
@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.51%. Comparing base (df7da68) to head (27f67db).
Report is 5 commits behind head on main.

❗ Current head 27f67db differs from pull request most recent head f27f3c0. Consider uploading reports for the commit f27f3c0 to get more accurate results

Files Patch % Lines
sdv/metadata/visualization.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1891   +/-   ##
=======================================
  Coverage   97.51%   97.51%           
=======================================
  Files          51       51           
  Lines        5119     5119           
=======================================
  Hits         4992     4992           
  Misses        127      127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fealho fealho force-pushed the issue-1704-py12 branch 6 times, most recently from 318f0e7 to abbe27e Compare April 10, 2024 16:29
@fealho fealho marked this pull request as ready for review April 10, 2024 17:07
@fealho fealho requested a review from a team as a code owner April 10, 2024 17:07
@fealho fealho requested review from amontanez24 and pvk-developer and removed request for a team April 10, 2024 17:07
pyproject.toml Outdated
'ctgan>=0.9.0',
'deepecho>=0.5',
"pandas>=1.5.0;python_version>='3.11' and python_version<'3.12'",
"pandas>=2.0.2;python_version>='3.12'",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required due to this issue.

Copy link
Member

@pvk-developer pvk-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frances-h frances-h mentioned this pull request Apr 12, 2024
@fealho fealho merged commit 9cbf097 into main Apr 12, 2024
46 checks passed
@fealho fealho deleted the issue-1704-py12 branch April 12, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Python 3.12
5 participants