Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin pandas #72

Merged
merged 3 commits into from
Apr 28, 2023
Merged

Unpin pandas #72

merged 3 commits into from
Apr 28, 2023

Conversation

frances-h
Copy link
Contributor

Resolve #69

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.14 ⚠️

Comparison is base (3e4339f) 78.91% compared to head (e4db623) 78.77%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage   78.91%   78.77%   -0.14%     
==========================================
  Files           7        7              
  Lines         721      721              
==========================================
- Hits          569      568       -1     
- Misses        152      153       +1     
Impacted Files Coverage Δ
deepecho/models/base.py 20.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frances-h frances-h marked this pull request as ready for review April 26, 2023 19:19
@frances-h frances-h requested a review from a team as a code owner April 26, 2023 19:19
@frances-h frances-h requested review from pvk-developer and fealho and removed request for a team April 26, 2023 19:19
Copy link
Member

@pvk-developer pvk-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you edited the wrong line on the setup.py, after that it should be good to merge ;)

setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@frances-h frances-h requested a review from pvk-developer April 27, 2023 17:44
Copy link
Member

@pvk-developer pvk-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@frances-h frances-h merged commit e160751 into master Apr 28, 2023
@frances-h frances-h deleted the issue-69-unpin-pandas branch April 28, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove upper bound for pandas
4 participants