Allow support for spec suites using mocking frameworks other than RSpec Mocks #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows support for spec suites using other mocking frameworks
|
Excellent catch, thanks for fixing! We are using mocha in an old app that we still maintain, and I bet this will help upgrading. |
|
Released in 0.8.0 |
|
Awesome, thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the matcher file has a hardcoded
requirestatement for RSpec Mocks (added in #2). This line is causing errors for us, because we use RR in our specs rather than RSpec Mocks. Anybody using any of the other mocking frameworks (e.g. Mocha, FlexMock) is probably also going to run into similar issues.It doesn't look like there's anywhere in the gem where RSpec Mocks is used, and the tests all seem to pass with the require statement removed.
PS: great gem. Love it!