Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DQN TensorFlow2 implementation #59

Merged
merged 34 commits into from
Feb 21, 2023
Merged

DQN TensorFlow2 implementation #59

merged 34 commits into from
Feb 21, 2023

Conversation

sdpkjc
Copy link
Owner

@sdpkjc sdpkjc commented Jan 2, 2023 •
edited
Loading

Description

dqn_tf, dqn_atari_tf, ddqn_tf, pdqn_tf TensorFlow2 implementation

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have run the pre-commit checks with pre-commit run --all-files
  • I have updated the documentation and previewed the changes via mkdocs serve
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Jan 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
abcdrl ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 14, 2023 at 11:40AM (UTC)

@sdpkjc sdpkjc self-assigned this Jan 2, 2023
This was referenced Jan 3, 2023
Closed
Closed
@sdpkjc sdpkjc changed the title TensorFlow2 implementation DQN TensorFlow2 implementation Jan 9, 2023
@sdpkjc sdpkjc mentioned this pull request Jan 10, 2023
Open
5 tasks
@sdpkjc
Copy link
Owner Author

sdpkjc commented Jan 10, 2023 •
edited
Loading

next step:

  • overhual algs file name
  • add tensorflow tests
  • overhual wrapper in multi-dl-framework
  • ddqn_tf, pdqn_tf
  • dqn_atari_tf
  • update docs
  • run benchmark

sdpkjc
sdpkjc commented Jan 11, 2023
View reviewed changes
Copy link
Owner Author

@sdpkjc sdpkjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdpkjc
Copy link
Owner Author

sdpkjc commented Jan 12, 2023

rerun torch benchmark

@sdpkjc
Copy link
Owner Author

sdpkjc commented Feb 20, 2023

🚀

sdpkjc
sdpkjc commented Feb 21, 2023
View reviewed changes
Copy link
Owner Author

@sdpkjc sdpkjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdpkjc
Copy link
Owner Author

sdpkjc commented Feb 21, 2023

/approve

@sdpkjc sdpkjc merged commit c3551a0 into main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sdpkjc sdpkjc

Labels
🔍 Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sdpkjc