Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling time limits problem #32

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Conversation

sdpkjc
Copy link
Owner

@sdpkjc sdpkjc commented Dec 6, 2022

Description

In an infinite environment, our code doesn't behave properly. This is because of the problem of Handling Time Limits. Refer to the latest gymnasium documentation and It may be possible to solve this problem by only using the terminated signal as the done signal in the training.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have run the pre-commit checks with pre-commit run --all-files
  • I have updated the documentation and previewed the changes via mkdocs serve
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Dec 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
abcdrl ✅ Ready (Inspect) Visit Preview Dec 6, 2022 at 2:08AM (UTC)

@sdpkjc
Copy link
Owner Author

sdpkjc commented Dec 6, 2022

/approve

@repository-commander
Copy link

Approving changes of this pull_request as requested by @sdpkjc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant