Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ddqn target #11

Merged
merged 1 commit into from
Nov 20, 2022
Merged

Fix ddqn target #11

merged 1 commit into from
Nov 20, 2022

Conversation

sdpkjc
Copy link
Owner

@sdpkjc sdpkjc commented Nov 20, 2022 

_, target_argmax = self.model.value(data.next_observations).max(dim=1)
target_max = self.model_t.value(data.next_observations).gather(1, target_argmax.unsqueeze(1)).squeeze()

@vercel
Copy link

vercel bot commented Nov 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
abcdrl ✅ Ready (Inspect) Visit Preview Nov 20, 2022 at 11:53AM (UTC)

@sdpkjc
Copy link
Owner Author

sdpkjc commented Nov 20, 2022

/approve

@repository-commander
Copy link

Approving changes of this pull_request as requested by @sdpkjc

@sdpkjc sdpkjc self-assigned this Nov 20, 2022
@sdpkjc sdpkjc merged commit bcd3c43 into master Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@repository-commander repository-commander[bot] repository-commander[bot] approved these changes

Assignees

@sdpkjc sdpkjc

Labels
✨ Merged:
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sdpkjc