Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select file (model, IR) directory instead of a single file #286

Merged
merged 2 commits into from
Jun 11, 2023

Conversation

sdatkinson
Copy link
Owner

Resolves #281 by giving NAM the permission for all of the directory at once.

Picks the first model in the directory to start; use arrows/dropdown menu to go from there.

Known issue: if the first file in the directory is invalid (e.g. a stereo IR), then this doesn't work cf #285 (will fix next)

@sdatkinson
Copy link
Owner Author

I think I prefer this over #284 🙂

@sdatkinson sdatkinson merged commit 4a028ef into main Jun 11, 2023
@sdatkinson sdatkinson deleted the issue-281-dir branch June 11, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] macOS standalone: Warn users with models not in Music/ directory
1 participant