Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit chrono version to avoid test failure #918

Closed
wants to merge 1 commit into from

Conversation

Lorak-mmk
Copy link
Collaborator

Chrono 0.4.32 introduced a breaking change which cause our tests to fail. Avoid using the new version until chrono is fixed.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

Chrono 0.4.32 introduced a breaking change which cause our tests to fail. Avoid using the new version until chrono is fixed.
@Lorak-mmk
Copy link
Collaborator Author

Closing, succeeded by #918

@piodul
Copy link
Collaborator

piodul commented Jan 24, 2024

Closing, succeeded by #918

I think you meant #919 instead. Anyway, #919 was merged, so I'll actually close #918 (this PR) right now.

@piodul piodul closed this Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants