dev-deps: downgrade criterion to 0.4 #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `criterion` library, since version 0.5, depends on `clap` v4 or higher. Recently, `clap` 4.4.0 has been released which has bumped its required MSRV to 1.70.0. Our MSRV is still 1.65.0. Apparently, the cargo resolver isn't smart enough to choose an older version of `clap` which still supports 1.65.0, so this breaks our MSRV build in CI (see rust-lang/cargo#9930). In order to unblock the CI without checking in Cargo.toml - which would be annoying - the `criterion` dependency is downgraded to 0.4. This library is only used for benchmarks and is a dev-dependency, so it's not a big deal. No changes in the code are necessary. In the future, if we decide to bump MSRV to 1.70.0 or further, we can update the dependency.
wprzytula
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
criterionlibrary, since version 0.5, depends onclapv4 or higher. Recently,clap4.4.0 has been released which has bumped its required MSRV to 1.70.0. Our MSRV is still 1.65.0. Apparently, the cargo resolver isn't smart enough to choose an older version ofclapwhich still supports 1.65.0, so this breaks our MSRV build in CI (see rust-lang/cargo#9930).In order to unblock the CI without checking in Cargo.toml - which would be annoying - the
criteriondependency is downgraded to 0.4. This library is only used for benchmarks and is a dev-dependency, so it's not a big deal. No changes in the code are necessary.In the future, if we decide to bump MSRV to 1.70.0 or further, we can update the dependency.
Pre-review checklist
I added relevant tests for new features and bug fixes.I have provided docstrings for the public items that I want to introduce.I have adjusted the documentation in./docs/source/.I added appropriateFixes:annotations to PR description.