statement: unpub StatementConfig #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`StatementConfig` is only used internally and does not appear in any public API. It is made pub(crate) together with its fields so that we have more flexibility in changing it without introducing a breaking change.
As StatementConfig is no longer `pub`, we can move retry_policy field there, instead of having it directly on Query, PreparedStatement and Batch.
wprzytula
force-pushed
the
unpub-statement-config
branch
from
16ad324 to
66b06ab
Compare
wprzytula
added
API-stability
Passing it separately is no longer needed after retry policy is put inside `StatementConfig`.
piodul
approved these changes
Jul 31, 2023
wprzytula
added a commit
to wprzytula/scylla-rust-driver
that referenced
this pull request
Aug 28, 2023
Even though scylladb#701 was fixed with scylladb#772, a TODO was left. Now it misleadingly points to `contents`. It is thus removed.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StatementConfigis only used internally and does not appear in any public API.pub(crate)together with its fields so that we have more flexibility in changing it without introducing a breaking change.retry_policyfield is moved fromQuery,PreparedStatementandBatchintoStatementConfig, as it suits there best.Refs: #660
Fixes: #701
Pre-review checklist
[ ] I added relevant tests for new features and bug fixes.[ ] I have provided docstrings for the public items that I want to introduce.[ ] I have adjusted the documentation in./docs/source/.Fixes:annotations to PR description.