Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f_errors: remove unused variant from ColumnSpecParseErrorKind #1201

Merged

Conversation

muzarski
Copy link
Contributor

@muzarski muzarski commented Feb 5, 2025

In #1135 we removed a check for the table spec across different column specs. Since we wanted to release it in a patch release, the corresponding error variant was not removed (not to introduce API breaking changes).

This commit removes the unused variant.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • [ ] I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • [ ] I have provided docstrings for the public items that I want to introduce.
  • [ ] I have adjusted the documentation in ./docs/source/.
  • [ ] I added appropriate Fixes: annotations to PR description.

@muzarski muzarski self-assigned this Feb 5, 2025
@muzarski muzarski added this to the 0.16.0 milestone Feb 5, 2025
@muzarski muzarski added the API-stability Part of the effort to stabilize the API label Feb 5, 2025
@muzarski muzarski requested review from Lorak-mmk and wprzytula and removed request for Lorak-mmk February 5, 2025 13:07
In scylladb#1135 we removed a check for the table spec across different
column specs. Since we wanted to release it in a patch release, the corresponding
error variant was not removed (not to introduce API breaking changes).

This commit removes the unused variant.
@muzarski muzarski force-pushed the unused-column-spec-parse-error-kind branch from 8602ca3 to 227155a Compare February 5, 2025 13:07
@muzarski muzarski requested a review from Lorak-mmk February 5, 2025 13:08
@github-actions github-actions bot added the semver-checks-breaking cargo-semver-checks reports that this PR introduces breaking API changes label Feb 5, 2025
Copy link

github-actions bot commented Feb 5, 2025

cargo semver-checks detected some API incompatibilities in this PR.
Checked commit: 227155a

See the following report for details:

cargo semver-checks output
./scripts/semver-checks.sh --baseline-rev 699e3895ea9fde34fb250e5581207ceee53dd2aa
+ cargo semver-checks -p scylla -p scylla-cql --baseline-rev 699e3895ea9fde34fb250e5581207ceee53dd2aa
     Cloning 699e3895ea9fde34fb250e5581207ceee53dd2aa
    Building scylla v0.15.0 (current)
       Built [  23.812s] (current)
     Parsing scylla v0.15.0 (current)
      Parsed [   0.049s] (current)
    Building scylla v0.15.0 (baseline)
       Built [  22.108s] (baseline)
     Parsing scylla v0.15.0 (baseline)
      Parsed [   0.056s] (baseline)
    Checking scylla v0.15.0 -> v0.15.0 (no change)
     Checked [   0.124s] 127 checks: 127 pass, 0 skip
     Summary no semver update required
    Finished [  47.137s] scylla
    Building scylla-cql v0.4.0 (current)
       Built [  10.845s] (current)
     Parsing scylla-cql v0.4.0 (current)
      Parsed [   0.026s] (current)
    Building scylla-cql v0.4.0 (baseline)
       Built [  10.937s] (baseline)
     Parsing scylla-cql v0.4.0 (baseline)
      Parsed [   0.027s] (baseline)
    Checking scylla-cql v0.4.0 -> v0.4.0 (no change)
     Checked [   0.108s] 127 checks: 126 pass, 1 fail, 0 warn, 0 skip

--- failure enum_variant_missing: pub enum variant removed or renamed ---

Description:
A publicly-visible enum has at least one variant that is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/enum_variant_missing.ron

Failed in:
  variant ColumnSpecParseErrorKind::TableSpecDiffersAcrossColumns, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-699e3895ea9fde34fb250e5581207ceee53dd2aa/4eda4016a3500346a2fafc3e0edc84d78aee3428/scylla-cql/src/frame/frame_errors.rs:430

     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  22.513s] scylla-cql
make: *** [Makefile:61: semver-rev] Error 1

@Lorak-mmk Lorak-mmk modified the milestones: 0.16.0, 1.0.0 Feb 5, 2025
@wprzytula wprzytula merged commit e1bf271 into scylladb:main Feb 6, 2025
11 checks passed
@Lorak-mmk Lorak-mmk mentioned this pull request Mar 4, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API-stability Part of the effort to stabilize the API semver-checks-breaking cargo-semver-checks reports that this PR introduces breaking API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants