Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codewide: rename remnants of cluster data to state #1187

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wprzytula
Copy link
Collaborator

There were multiple places where ClusterState was still referred to as ClusterData:

  • Session::get_cluster_data(),
  • Cluster::get_data(),
  • variable names,
  • comments and docstrings.

All were renamed.

Supplements #1163.

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • [ ] I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • [ ] I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • [ ] I added appropriate Fixes: annotations to PR description.

There were multiple places where ClusterState was still referred to as
ClusterData:
- Session::get_cluster_data(),
- Cluster::get_data(),
- variable names,
- comments and docstrings.

All were renamed.
@wprzytula wprzytula requested review from Lorak-mmk and muzarski and removed request for Lorak-mmk February 1, 2025 10:33
@wprzytula wprzytula self-assigned this Feb 1, 2025
@wprzytula wprzytula requested a review from Lorak-mmk February 1, 2025 10:33
@wprzytula wprzytula added this to the 0.16.0 milestone Feb 1, 2025
Copy link

github-actions bot commented Feb 1, 2025

cargo semver-checks detected some API incompatibilities in this PR.
Checked commit: 6aaee31

See the following report for details:

cargo semver-checks output
./scripts/semver-checks.sh --baseline-rev 448502ca1db6228ab3d1d6108db78664e1dfddb6
+ cargo semver-checks -p scylla -p scylla-cql --baseline-rev 448502ca1db6228ab3d1d6108db78664e1dfddb6
     Cloning 448502ca1db6228ab3d1d6108db78664e1dfddb6
    Building scylla v0.15.0 (current)
       Built [  23.019s] (current)
     Parsing scylla v0.15.0 (current)
      Parsed [   0.050s] (current)
    Building scylla v0.15.0 (baseline)
       Built [  22.728s] (baseline)
     Parsing scylla v0.15.0 (baseline)
      Parsed [   0.048s] (baseline)
    Checking scylla v0.15.0 -> v0.15.0 (no change)
     Checked [   0.131s] 127 checks: 126 pass, 1 fail, 0 warn, 0 skip

--- failure inherent_method_missing: pub method removed or renamed ---

Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/inherent_method_missing.ron

Failed in:
  GenericSession::get_cluster_data, previously in file /home/runner/work/scylla-rust-driver/scylla-rust-driver/target/semver-checks/git-448502ca1db6228ab3d1d6108db78664e1dfddb6/65b2eff398a4ccb7c9c581eed694c6b5b77c88c7/scylla/src/client/session.rs:1737

     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [  47.200s] scylla
    Building scylla-cql v0.4.0 (current)
       Built [  11.503s] (current)
     Parsing scylla-cql v0.4.0 (current)
      Parsed [   0.034s] (current)
    Building scylla-cql v0.4.0 (baseline)
       Built [  10.888s] (baseline)
     Parsing scylla-cql v0.4.0 (baseline)
      Parsed [   0.033s] (baseline)
    Checking scylla-cql v0.4.0 -> v0.4.0 (no change)
     Checked [   0.129s] 127 checks: 127 pass, 0 skip
     Summary no semver update required
    Finished [  23.212s] scylla-cql
make: *** [Makefile:61: semver-rev] Error 1

@github-actions github-actions bot added the semver-checks-breaking cargo-semver-checks reports that this PR introduces breaking API changes label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-checks-breaking cargo-semver-checks reports that this PR introduces breaking API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants