[v1.15] Lazily initialize assets #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assets kept as global variables are moved to structure which is lazily initialized upon first usage. This speeds up binary startup as cpu heavy initialization is done at later stage. Thanks to this, contianers which are running side commands - usually under contstrained resources - doesn't need to process them if they are not using them. ScyllaDB-ignition container which previously required ~2min to start the command: ``` I1203 18:59:28.325125 1 operator/cmd.go:21] maxprocs: Updating GOMAXPROCS=1: using minimum allowed GOMAXPROCS I1203 19:01:37.837439 1 operator/ignition.go:156] run-ignition version "v0.0.0-alpha.0-110-g9d9a586" ``` With this change it's almost immediate: ``` I1203 20:04:35.334993 1 operator/cmd.go:21] maxprocs: Updating GOMAXPROCS=[1]: using minimum allowed GOMAXPROCS I1203 20:04:35.337488 1 operator/ignition.go:156] run-ignition version "v1.16.0-alpha.0-23-g70ff0f6" ```
zimnx
added
priority/important-soon
scylla-operator-bot
bot
added
the
size/L
scylla-operator-bot
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tnozicka, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2233