Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.15] Pin image tags to v1.15 #2200

Merged
merged 2 commits into from
Nov 26, 2024
Merged

[v1.15] Pin image tags to v1.15 #2200

merged 2 commits into from
Nov 26, 2024

Conversation

zimnx
Copy link
Collaborator

@zimnx zimnx commented Nov 26, 2024

In preparation for v1.15, manifest image was pinned to 1.15.

@zimnx zimnx added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. labels Nov 26, 2024
@scylla-operator-bot scylla-operator-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 26, 2024
@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2024
rzetelskik
rzetelskik approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@rzetelskik rzetelskik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zimnx zimnx mentioned this pull request Nov 26, 2024
Closed
@tnozicka
Copy link
Contributor

/hold
the docs substitutions need to be also pinned
https://github.com/scylladb/scylla-operator/blob/v1.15/docs/source/conf.py#L58

@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 26, 2024
@tnozicka
Copy link
Contributor

/hold cancel
(this will be harder with sphinx-multiversion)

@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 26, 2024
@tnozicka
Copy link
Contributor

filed #2204 to track the manifest versioning

@scylla-operator-bot scylla-operator-bot bot merged commit 8ca7e2a into scylladb:v1.15 Nov 26, 2024
12 checks passed
@zimnx zimnx deleted the pin-image-v1.15 branch November 26, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzetelskik rzetelskik rzetelskik approved these changes

@tnozicka tnozicka Awaiting requested review from tnozicka

Assignees

@rzetelskik rzetelskik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zimnx @tnozicka @rzetelskik