Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify scheme usage #2195

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Unify scheme usage #2195

merged 1 commit into from
Nov 25, 2024

Conversation

zimnx
Copy link
Collaborator

@zimnx zimnx commented Nov 25, 2024

Webhook was using outdated scheme defined in the same package. The rest of the project uses one defined in pkg/scheme which is maintained and up to date. This changes webhook to use the right scheme to deserialize object.

Webhook was using outdated scheme defined in the same package.
The rest of the project uses one defined in pkg/scheme which is maintained and up to date.
This changes webhook to use the right scheme to deserialize object.
@zimnx zimnx added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Nov 25, 2024
@scylla-operator-bot scylla-operator-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 25, 2024
@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2024
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot merged commit b2b22b8 into scylladb:master Nov 25, 2024
12 checks passed
@zimnx zimnx deleted the unify-scheme branch November 25, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants