Add ClusterDomain fields into ScyllaOperatorConfig Status #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimnx
added
kind/feature
scylla-operator-bot
bot
added
the
size/L
scylla-operator-bot
bot
added
the
approved
tnozicka
reviewed
Nov 7, 2024
zimnx
changed the title
|
@rzetelskik @tnozicka ptal, it's awaiting your feedback |
tnozicka
reviewed
Nov 12, 2024
rzetelskik
reviewed
Nov 12, 2024
zimnx
force-pushed
the
clusterdomain
branch
2 times, most recently
from
9fe21b6 to
e1767ee
Compare
rzetelskik
reviewed
Nov 13, 2024
tnozicka
reviewed
Nov 13, 2024
Discovered Kubernetes cluster domain is saved as ScyllaOperatorConfig status field. The domain can be used as a Kubernetes cluster indentifier. Conditions added to ScyllaOperatorConfig status carry information regarding reconcilation of ClusterDomain automation.
tnozicka
approved these changes
Nov 14, 2024
scylla-operator-bot
bot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tnozicka, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
scylla-operator-bot
bot
merged commit 02e630d
into
scylladb:master
12 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered Kubernetes cluster domain is saved as ScyllaOperatorConfig status field. The domain can be used as a Kubernetes cluster indentifier.
Conditions added to ScyllaOperatorConfig status carry information regarding reconcilation of ClusterDomain automation.