-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an E2E test for NodeConfig mount degraded condition propagation for mounts over corrupted xfs filesystems #2178
Add an E2E test for NodeConfig mount degraded condition propagation for mounts over corrupted xfs filesystems #2178
Conversation
a6d93ea
to
9e48f16
Compare
…or mounts over corrupted xfs filesystems
9e48f16
to
89ea299
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could be done simpler by creating a broken XFS initially using a pod in the preNodeConfigCreationFunc and reusing more of the existing code (avoids the extra rollout wait and patch) but I don't feel strong
/approve
/assign @zimnx
Depends on what you consider simpler - I started by trying to do it this way but at some point I realised the client pod started to turn into the nodeconfig controller because it had to perform the exact same steps to set it up. I think this way is clearer in terms of highlighting the broken setup. In terms of the test entry complexity it's admittedly worse - perhaps the test table could use a rehaul. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rzetelskik, tnozicka, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes: This PR adds an e2e test verifying that NodeConfig ends up with a degraded status condition when trying to mount over a corrupted xfs filesystem. The behaviour itself, as requested by #1158, was already there since merging #2134.
Which issue is resolved by this Pull Request:
Resolves #1558
/priority important-longterm