Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use server-side apply when deploying aggregated manifests #2170

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Use server-side apply when deploying aggregated manifests #2170

merged 1 commit into from
Oct 29, 2024

Conversation

zimnx
Copy link
Collaborator

@zimnx zimnx commented Oct 29, 2024

Client side apply doesn't work as our CRD got too big and cannot be put in annotation which isn't necessary when server-side apply is used.

Fixes #2157

@zimnx
Use server-side apply when deploying aggregated manifests
f38391f 
Client side apply doesn't work as our CRD got too big and cannot be put in annotation which isn't necessary when server-side apply is used.
@zimnx zimnx added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/documentation Categorizes issue or PR as related to documentation. labels Oct 29, 2024
@scylla-operator-bot scylla-operator-bot bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 29, 2024
tnozicka
tnozicka approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
thanks

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tnozicka
Copy link
Contributor

@zimnx pls backport it to 1.14 (latest docs) as well

@scylla-operator-bot scylla-operator-bot bot merged commit d88ebf1 into scylladb:master Oct 29, 2024
9 checks passed
@zimnx zimnx deleted the fix-documentation-apply branch October 29, 2024 10:53
This was referenced Oct 29, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnozicka tnozicka tnozicka approved these changes

@rzetelskik rzetelskik Awaiting requested review from rzetelskik

Assignees

@tnozicka tnozicka

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CustomResourceDefinition too long error with latest Scylla Operator version
2 participants
@zimnx @tnozicka