-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused fields from ScyllaDB and ScyllaDBManagerAgent datacenter wide properties #2169
Remove unused fields from ScyllaDB and ScyllaDBManagerAgent datacenter wide properties #2169
Conversation
…r wide properties Datacenter wide properties of ScyllaDB and ScyllaDBManagerAgent should be specified in RackTemplate. These fields were unused and put there by mistake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
(lgtm)
/assign @rzetelskik
@tnozicka: GitHub didn't allow me to assign the following users: rzetelski. Note that only scylladb members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rzetelskik, tnozicka, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Just for the record - this is fine to do because none of the API fields have been released yet. Otherwise the backward compatibility guarantees would apply. |
Datacenter wide properties of ScyllaDB and ScyllaDBManagerAgent should be specified in RackTemplate.
These fields were unused and put there by mistake.