Fix manager tasks' status errors not being cleared on failed status updates for tasks present in manager state

[rzetelskik]

Description of your changes: Manager task errors shouldn't be kept when building status for tasks existing in manager state and only cleared on status update, since if the status update fails, the error is retained even though the error no longer occurs. For tasks in manager state, if the error reappears, it will be propagated again. This bug is currently being covered by the logic comparing our spec with manager state (hot loop), but with #2143 this will no longer be the case, hence this is a prerequisite for #2143.

Which issue is resolved by this Pull Request:
Resolves #

/kind bug
/priority important-soon
/cc

[scylla-operator-bot]

@rzetelskik: GitHub didn't allow me to request PR reviews from the following users: rzetelskik.

Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

…pdates for tasks present in manager state

Description of your changes: wip

Which issue is resolved by this Pull Request:
Resolves #

/kind bug
/priority important-soon
/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[rzetelskik]

@rzetelskik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-parallel 66f8227 link true /test e2e-gke-parallel
Full PR test history. Your PR dashboard.

#2061 (comment)
known manager flake with colliding snapshot tags, unrelated
/retest

[rzetelskik]

@rzetelskik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-parallel 66f8227 link true /test e2e-gke-parallel
Full PR test history. Your PR dashboard.

new flake #2145, unrelated

[rzetelskik]

/test images e2e-gke-parallel

[zimnx]

lgtm
/assign tnozicka

[rzetelskik]

@rzetelskik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-parallel 66f8227 link true /test e2e-gke-parallel
Full PR test history. Your PR dashboard.

#1028 (comment)
shardawareness flake, unrelated

/retest

[tnozicka]

/approve
/lgtm

[scylla-operator-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tnozicka,zimnx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment