Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update golang to 1.23 #2122

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Update golang to 1.23 #2122

merged 1 commit into from
Oct 22, 2024

Conversation

tnozicka
Copy link
Contributor

@tnozicka tnozicka commented Sep 18, 2024 •
edited
Loading

@tnozicka tnozicka added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. labels Sep 18, 2024
@scylla-operator-bot scylla-operator-bot bot added the area/dependency Issues or PRs related to dependency changes label Sep 18, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 18, 2024
@tnozicka tnozicka changed the title Update golang to 1.23 [WIP] Update golang to 1.23 Sep 18, 2024
@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2024
@tnozicka
Copy link
Contributor Author

https://github.com/scylladb/scylla-operator-release/pull/335 landed
/retest

@tnozicka tnozicka changed the title [WIP] Update golang to 1.23 Update golang to 1.23 Oct 22, 2024
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2024
rzetelskik
rzetelskik reviewed Oct 22, 2024
View reviewed changes
@rzetelskik
Copy link
Member

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2024
@scylla-operator-bot scylla-operator-bot bot merged commit c8109cc into scylladb:master Oct 22, 2024
12 checks passed
@tnozicka tnozicka deleted the update-golang branch October 23, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzetelskik rzetelskik rzetelskik left review comments

@zimnx zimnx Awaiting requested review from zimnx

Assignees

@rzetelskik rzetelskik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. lgtm Indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tnozicka @rzetelskik