Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #2116

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

tnozicka
Copy link
Contributor

@tnozicka tnozicka commented Sep 9, 2024

Description of your changes:
Updates dependencies to get the latest fixes.

@tnozicka tnozicka added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Sep 9, 2024
@scylla-operator-bot scylla-operator-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 9, 2024
@scylla-operator-bot scylla-operator-bot bot requested a review from zimnx September 9, 2024 11:36
@scylla-operator-bot scylla-operator-bot bot added the area/dependency Issues or PRs related to dependency changes label Sep 9, 2024
@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2024
@rzetelskik
Copy link
Member

Since you're updating SM client here, I think we can get rid of these two replacements:

	github.com/rclone/rclone => github.com/scylladb/rclone v1.54.1-0.20240312172628-afe1fd2aa65e
	google.golang.org/api => github.com/scylladb/google-api-go-client v0.34.1-patched

Ref: scylladb/scylla-manager#4010

@tnozicka
Copy link
Contributor Author

tnozicka commented Sep 9, 2024

removed, thx

@rzetelskik
Copy link
Member

I suppose the same goes for github.com/Azure/azure-storage-blob-go

$ go mod why -m github.com/Azure/azure-storage-blob-go
# github.com/Azure/azure-storage-blob-go
github.com/scylladb/scylla-operator/pkg/cmd/operator
github.com/scylladb/scylla-manager/v3/pkg/managerclient
github.com/scylladb/scylla-manager/v3/pkg/managerclient.test
github.com/scylladb/scylla-manager/v3/pkg/service/backup
github.com/scylladb/scylla-manager/v3/pkg/scyllaclient
github.com/scylladb/scylla-manager/v3/pkg/rclone/rcserver
github.com/rclone/rclone/backend/azureblob
github.com/Azure/azure-storage-blob-go/azblob

@tnozicka
Copy link
Contributor Author

removed as well

Copy link
Member

@rzetelskik rzetelskik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
/assign zimnx

Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2024
@tnozicka
Copy link
Contributor Author

(clean rebase)

@zimnx
Copy link
Collaborator

zimnx commented Sep 12, 2024

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2024
@scylla-operator-bot scylla-operator-bot bot merged commit be399e2 into scylladb:master Sep 12, 2024
12 checks passed
@tnozicka tnozicka deleted the update-deps branch September 12, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants