Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parametrize webhook command #2114

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

zimnx
Copy link
Collaborator

@zimnx zimnx commented Sep 6, 2024

Webhook command accepts a map of validators making this command be reusable and easily extensible.

@zimnx zimnx added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Sep 6, 2024
@scylla-operator-bot scylla-operator-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 6, 2024
@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2024
@zimnx zimnx force-pushed the parametrize-webhook branch from b35a00b to ac2ad3c Compare September 9, 2024 11:41
@zimnx zimnx requested a review from tnozicka September 9, 2024 11:42
Copy link
Member

@rzetelskik rzetelskik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but +1 for @tnozicka's comment #2114 (comment)

@zimnx zimnx force-pushed the parametrize-webhook branch from ac2ad3c to 1cc8deb Compare September 9, 2024 13:12
@zimnx zimnx requested a review from rzetelskik September 9, 2024 13:12
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2024
@tnozicka
Copy link
Contributor

/retest

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zimnx
Copy link
Collaborator Author

zimnx commented Sep 10, 2024

/retest

Webhook command accepts a map of validators making this command be reusable and easily customizable.
@zimnx zimnx force-pushed the parametrize-webhook branch from 1cc8deb to 3c0f960 Compare September 10, 2024 12:05
@scylla-operator-bot scylla-operator-bot bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2024
@zimnx
Copy link
Collaborator Author

zimnx commented Sep 10, 2024

clean rebase

@zimnx zimnx requested a review from tnozicka September 10, 2024 13:08
@tnozicka
Copy link
Contributor

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2024
@scylla-operator-bot scylla-operator-bot bot merged commit bb172c4 into scylladb:master Sep 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants