Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable building v1.14 documentation #2109

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

tnozicka
Copy link
Contributor

@tnozicka tnozicka commented Sep 3, 2024

Description of your changes:
This PR enables building v1.14 documentation.

@tnozicka tnozicka added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. labels Sep 3, 2024
@scylla-operator-bot scylla-operator-bot bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 3, 2024
@tnozicka tnozicka changed the base branch from master to v1.14 September 3, 2024 19:00
@tnozicka tnozicka changed the title Enable building v1.14 documentation [v1.14] Enable building v1.14 documentation Sep 3, 2024
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2024
@zimnx zimnx removed the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2024
@zimnx
Copy link
Collaborator

zimnx commented Sep 4, 2024

hmm, shouldn't this be pointed to master? Docs are built from master, content is taken from branches.

@zimnx
Copy link
Collaborator

zimnx commented Sep 4, 2024

I think it should, previous releases enabled docs on master:
#1329
#1755

@tnozicka tnozicka changed the title [v1.14] Enable building v1.14 documentation Enable building v1.14 documentation Sep 4, 2024
@tnozicka tnozicka changed the base branch from v1.14 to master September 4, 2024 08:21
@tnozicka
Copy link
Contributor Author

tnozicka commented Sep 4, 2024

it certainly should, changed back, thx

Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot merged commit bae3f9b into scylladb:master Sep 4, 2024
9 checks passed
@tnozicka tnozicka deleted the enable-1.14-docs branch September 4, 2024 12:57
@tnozicka tnozicka mentioned this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants