Migrate controllers to reconcile v1alpha1.ScyllaDBDatacenter #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zimnx: GitHub didn't allow me to request PR reviews from the following users: zimnx. Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
scylla-operator-bot
bot
added
do-not-merge/work-in-progress
zimnx
force-pushed
the
scylladbdatacenter-controllers
branch
from
0a7024d to
51feef6
Compare
scylla-operator-bot
bot
removed
the
needs-rebase
zimnx
force-pushed
the
scylladbdatacenter-controllers
branch
13 times, most recently
from
e8766e4 to
b3f1f6f
Compare
zimnx
changed the title
scylla-operator-bot
bot
removed
the
do-not-merge/work-in-progress
zimnx
added
kind/feature
scylla-operator-bot
bot
removed
do-not-merge/needs-kind
zimnx
changed the title
zimnx
force-pushed
the
scylladbdatacenter-controllers
branch
5 times, most recently
from
7aed2b1 to
a0f75de
Compare
zimnx
force-pushed
the
scylladbdatacenter-controllers
branch
2 times, most recently
from
9ebba10 to
793c71d
Compare
zimnx
force-pushed
the
scylladbdatacenter-controllers
branch
2 times, most recently
from
7e490f2 to
35129c9
Compare
scylla-operator-bot
bot
added
the
needs-rebase
zimnx
force-pushed
the
scylladbdatacenter-controllers
branch
from
35129c9 to
b9dacb5
Compare
scylla-operator-bot
bot
removed
the
needs-rebase
…ScyllaDBDatacenter Most controllers which were working on v1.ScyllaCluster are migrated to use v1alpha1.ScyllaDBDatacenter. Except one which provide features not available yet in new API (Scylla Manager integration). New controller is responsible for releasing objects managed by current ScyllaCluster and migrating existing ScyllaClusters to ScyllaDBDatacenter. Released resources are adopted by the new ScyllaDBDatacenter object. Most of the work is based on [this proposal](https://github.com/scylladb/scylla-operator/blob/master/enhancements/proposals/1978-scylladbdatacenter-api/README.md). During implementation I found that ScyllaDB version upgrades weren't covered in the proposal. Previous implementation kept state of upgrade state machine within ScyllaCluster Status, where new API doesn't have it. Instead spoiling new API with it, upgrade state machine was changed to keep its state as a ConfigMap. Migrating controller is aware of it, and migrates the state before ScyllaDBDatacenter is created to make sure it's being picked up by changed ScyllaDBDatacenter controller.
zimnx
force-pushed
the
scylladbdatacenter-controllers
branch
4 times, most recently
from
bb2a464 to
1c4e463
Compare
zimnx
force-pushed
the
scylladbdatacenter-controllers
branch
from
1c4e463 to
128682d
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rzetelskik, tnozicka, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
scylla-operator-bot
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most controllers which were working on v1.ScyllaCluster are migrated to use v1alpha1.ScyllaDBDatacenter.
Except one which provide features not available yet in new API (Scylla Manager integration).
New controller is responsible for releasing objects managed by current ScyllaCluster and migrating existing ScyllaClusters to ScyllaDBDatacenter.
Released resources are adopted by the new ScyllaDBDatacenter object.
Most of the work is based on this proposal.
During implementation I found that ScyllaDB version upgrades weren't covered in the proposal. Previous implementation kept state of upgrade state machine within ScyllaCluster Status, where new API doesn't have it.
Instead spoiling new API with it, upgrade state machine was changed to keep its state as a ConfigMap.
Migrating controller is aware of it, and migrates the state before ScyllaDBDatacenter is created to make sure it's being picked up by changed ScyllaDBDatacenter controller.
Fixes #2038