Remove pre-rollout check validating ScyllaDB version #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimnx
added
priority/important-soon
scylla-operator-bot
bot
added
the
size/M
scylla-operator-bot
bot
added
the
approved
zimnx
force-pushed
the
remove-prerollout-check
branch
2 times, most recently
from
dafb557 to
42318e6
Compare
tnozicka
reviewed
Jul 24, 2024
There was a problem hiding this comment.
shouldn't you remove this as well?
scylla-operator/pkg/scyllafeatures/scyllafeatures.go
Lines 33 to 37 in eb144ac
Minimal versions which this check validated are already EOL, and we don't claim we support them in our documentation.
zimnx
force-pushed
the
remove-prerollout-check
branch
from
42318e6 to
a361077
Compare
yep, removed. |
scylla-operator-bot
bot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rzetelskik, tnozicka, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
Minimal versions which this check validated are already EOL, and we don't claim we support them in our documentation.
Which issue is resolved by this Pull Request:
Resolves #2034