Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve symlinks in NodeConfig's mount paths #2014

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Resolve symlinks in NodeConfig's mount paths #2014

merged 2 commits into from
Jul 15, 2024

Conversation

tnozicka
Copy link
Contributor

@tnozicka tnozicka commented Jul 9, 2024 •
edited
Loading

Description of your changes:
This PR allows NodeConfig to setup mounts for paths that contain symlinks.

This is especially important for distributions with immutable filesystems, like OpenShift using CoreOS with rpm-ostre, where important top level folders (e.g. /mnt) are symlinks.

Which issue is resolved by this Pull Request:
Resolves #1985

@tnozicka tnozicka added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jul 9, 2024
@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

@tnozicka: GitHub didn't allow me to request PR reviews from the following users: tnozicka.

Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Description of your changes:
TODO

Which issue is resolved by this Pull Request:
Resolves #1985

/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@scylla-operator-bot scylla-operator-bot bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 9, 2024
@scylla-operator-bot scylla-operator-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 10, 2024
@tnozicka tnozicka force-pushed the fix-mounts branch 2 times, most recently from 3689226 to 49364b3 Compare July 12, 2024 12:45
@tnozicka tnozicka changed the title [WIP] Resolve symlinks in mount path Resolve symlinks in mount path Jul 12, 2024
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 12, 2024
@tnozicka
Copy link
Contributor Author

/cc @zimnx @rzetelskik

@tnozicka tnozicka changed the title Resolve symlinks in mount path Resolve symlinks in NodeConfig's mount paths Jul 12, 2024
zimnx
zimnx approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
/assign rzetelskik

rzetelskik
rzetelskik approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@rzetelskik rzetelskik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tnozicka
Copy link
Contributor Author

#1028 (comment)
/retest

@scylla-operator-bot scylla-operator-bot bot merged commit bd96111 into scylladb:master Jul 15, 2024
12 of 13 checks passed
@tnozicka tnozicka deleted the fix-mounts branch July 15, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimnx zimnx zimnx approved these changes

@rzetelskik rzetelskik rzetelskik approved these changes

Assignees

@rzetelskik rzetelskik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mount path /mnt/persistent-volumes is not canonical (contains a symlink).
3 participants
@tnozicka @zimnx @rzetelskik