Stop depending on default StorageClass' presence for ScyllaClusters in our manifests, examples, scripts and tests #2009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rzetelskik: GitHub didn't allow me to request PR reviews from the following users: rzetelskik. Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
scylla-operator-bot
bot
added
do-not-merge/work-in-progress
|
/test e2e-gke-multi-datacenter-parallel |
scylla-operator-bot
bot
added
size/M
rzetelskik
force-pushed
the
explicit-storageclass
branch
2 times, most recently
from
6cdeb78 to
48effab
Compare
rzetelskik
changed the title
scylla-operator-bot
bot
removed
the
do-not-merge/work-in-progress
rzetelskik
changed the title
rzetelskik
added
kind/feature
scylla-operator-bot
bot
removed
needs-priority
|
This is going to require explicitly setting /cc zimnx tnozicka |
tnozicka
reviewed
Jul 10, 2024
rzetelskik
changed the title
scylla-operator-bot
bot
added
the
do-not-merge/work-in-progress
rzetelskik
force-pushed
the
explicit-storageclass
branch
from
48effab to
cdb01e8
Compare
rzetelskik
changed the title
scylla-operator-bot
bot
removed
the
do-not-merge/work-in-progress
scylla-operator-bot
bot
added
the
approved
tnozicka
reviewed
Jul 11, 2024
|
/approve |
scylla-operator-bot
bot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rzetelskik, tnozicka, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rzetelskik
force-pushed
the
explicit-storageclass
branch
from
cdb01e8 to
568554b
Compare
scylla-operator-bot
bot
removed
the
lgtm
scylla-operator-bot
bot
added
the
do-not-merge/hold
|
/lgtm /hold cancel /retest |
scylla-operator-bot
bot
added
lgtm
1 task
tnozicka
added
kind/cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes: This PR addresses the issue of ScyllaClusters in our manifests, examples, scripts and tests often depending on the presence of a default StorageClass. This is problematic because there can only be one, indicated with an annotation, so setting/unsetting a default tends to break immutability.
Simultaneously I've tried not to break existing workflows and not have to change all of our CI jobs by expecting a StorageClass to be set explicitly. Therefore:
scyllacluster-storageclass-nameflag, which defaults to empty string, which is then interpreted as falling back to default storageclass (not setting storageClassName),storageClassNameset toscylladb-local-xfsby defaultSO_SCYLLACLUSTER_STORAGECLASS_NAMEwhich propagates to Scylla Manager's and tests' clusters; ifSO_SCYLLACLUSTER_STORAGECLASS_NAMEis explicitly set and empty,storageClassNameis not set, falling back to default storageclassWhich issue is resolved by this Pull Request:
Resolves #1990
/kind feature
/priority important-soon
/cc