Extend Handlers' EnqueueAll with enqueing func parameter #1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scylla-operator-bot
bot
added
kind/feature
scylla-operator-bot
bot
added
the
size/S
scylla-operator-bot
bot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rzetelskik, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
scylla-operator-bot
bot
added
the
approved
tnozicka
reviewed
Jun 17, 2024
scylla-operator-bot
bot
added
lgtm
tnozicka
added
kind/machinery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes: Conditionally enqueueing a subset of controlled objects seems to be a repeating use case in our codebase. This PR extends the EnqueueAll handler method parameters with an enqueueing function, making it possible to use function composition for such use cases.
Xref: https://github.com/scylladb/scylla-operator-enterprise/pull/25#discussion_r1638032987
Which issue is resolved by this Pull Request:
Resolves #
/kind feature
/priority important-longterm
/cc zimnx
/assign zimnx