Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move OperatorOptions flags to method #1959

Merged
merged 1 commit into from
Jun 10, 2024
+6 −2
Merged

Move OperatorOptions flags to method #1959

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pkg/cmd/operator/operator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,12 @@ func NewOperatorCmd(streams genericclioptions.IOStreams) *cobra.Command {
SilenceUsage: true,
}

o.AddFlags(cmd)

return cmd
}

func (o *OperatorOptions) AddFlags(cmd *cobra.Command) {
o.ClientConfig.AddFlags(cmd)
o.InClusterReflection.AddFlags(cmd)
o.LeaderElection.AddFlags(cmd)
Expand All @@ -112,8 +118,6 @@ func NewOperatorCmd(streams genericclioptions.IOStreams) *cobra.Command {
cmd.Flags().IntVarP(&o.CryptoKeyBufferSizeMin, "crypto-key-buffer-size-min", "", o.CryptoKeyBufferSizeMin, "Minimal number of pre-generated crypto keys that are used for quick certificate issuance. The minimum size is 1.")
cmd.Flags().IntVarP(&o.CryptoKeyBufferSizeMax, cryptoKeyBufferSizeMaxFlagKey, "", o.CryptoKeyBufferSizeMax, "Maximum number of pre-generated crypto keys that are used for quick certificate issuance. The minimum size is 1. If not set, it will adjust to be at least the size of crypto-key-buffer-size-min.")
cmd.Flags().DurationVarP(&o.CryptoKeyBufferDelay, "crypto-key-buffer-delay", "", o.CryptoKeyBufferDelay, "Delay is the time to wait when generating next certificate in the (min, max) range. Certificate generation bellow the min threshold is not affected.")

return cmd
}

func (o *OperatorOptions) Validate() error {
Expand Down