Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move webhook server resources definition to values #1946

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Move webhook server resources definition to values #1946

merged 1 commit into from
Jun 3, 2024

Conversation

chapsuk
Copy link
Contributor

@chapsuk chapsuk commented May 28, 2024

Description of your changes:

Allows to redefine Webhook Server resources

@scylla-operator-bot scylla-operator-bot bot requested review from rzetelskik and zimnx May 28, 2024 12:03
@scylla-operator-bot scylla-operator-bot bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 28, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

Hi @chapsuk. Thanks for your PR.

I'm waiting for a scylladb member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@scylla-operator-bot scylla-operator-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 28, 2024
zimnx
zimnx approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/lgtm
/ok-to-test

@scylla-operator-bot scylla-operator-bot bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 3, 2024
@scylla-operator-bot scylla-operator-bot bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 3, 2024
@zimnx zimnx added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 3, 2024
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Jun 3, 2024
@zimnx zimnx added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 3, 2024
@scylla-operator-bot scylla-operator-bot bot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 3, 2024
tnozicka
tnozicka approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chapsuk, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zimnx zimnx removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Jun 3, 2024
@zimnx
Copy link
Collaborator

zimnx commented Jun 3, 2024

/retest

@scylla-operator-bot scylla-operator-bot bot merged commit 1a6f2ca into scylladb:master Jun 3, 2024
12 checks passed
@chapsuk chapsuk deleted the add-operator-webhook-resources branch June 3, 2024 11:08
@chapsuk
Copy link
Contributor Author

chapsuk commented Jun 3, 2024

Thanks ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimnx zimnx zimnx approved these changes

@tnozicka tnozicka tnozicka approved these changes

@rzetelskik rzetelskik Awaiting requested review from rzetelskik

Assignees

@zimnx zimnx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chapsuk @zimnx @tnozicka