Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear Scylla Manager task errors from status after they've been successfully executed #1933

Merged
merged 1 commit into from
May 22, 2024
Merged

Clear Scylla Manager task errors from status after they've been successfully executed #1933

merged 1 commit into from
May 22, 2024

Conversation

rzetelskik
Copy link
Member

@rzetelskik rzetelskik commented May 21, 2024 •
edited
Loading

Description of your changes: Task error handling in the unified approach introduced in #1850 is missing clearing the errors after the tasks have been executed successfully. This PR fixes that.

Which issue is resolved by this Pull Request:
Resolves #1932

/kind bug
/priority important-soon
/cc zimnx

@scylla-operator-bot scylla-operator-bot bot requested a review from zimnx May 21, 2024 15:18
@scylla-operator-bot scylla-operator-bot bot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 21, 2024
@rzetelskik rzetelskik mentioned this pull request May 21, 2024
Merged
tnozicka
tnozicka approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/assign @zimnx

@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2024
zimnx
zimnx approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot merged commit e757930 into scylladb:master May 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimnx zimnx zimnx approved these changes

@tnozicka tnozicka tnozicka approved these changes

Assignees

@zimnx zimnx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scylla Manager task errors are not removed from status after they've been successfully executed
3 participants
@rzetelskik @zimnx @tnozicka