Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split ScyllaDB API status probes into a dedicated container #1926

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Split ScyllaDB API status probes into a dedicated container #1926

merged 2 commits into from
Jun 10, 2024

Conversation

tnozicka
Copy link
Contributor

@tnozicka tnozicka commented May 17, 2024 •
edited
Loading

Description of your changes:
At this point, ScyllaDB doesn't provide standardized /readyz and /healthz probes, so we serve a wrapper around CQL status (with some tweak) from an operator binary. This is unfortunately running in the same container as ScyllaDB and shares the cpu quota with it and has a negative impact on latency. There are others but this is a first step towards fixing and probes are really the really problematic ones as they serve continuously.

This PR move ScyllaDB probes to run in a separate container so it run in a separate cpu slice and doesn't affect ScyllaDB latency. This is also more architecturally clean and is a step forward to stop coping the operator binary into ScyllaDB container. It also abstracts generic probe patterns and related objects, so we can add other probes in the future, like for the Alternator or other APIs.

This also puts the probe logs at a correct place and no longer mix them with ScyllaDB logs.

Which issue is resolved by this Pull Request:
Resolves #620

@tnozicka tnozicka added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels May 17, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

@tnozicka: GitHub didn't allow me to request PR reviews from the following users: tnozicka.

Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Description of your changes:
TODO

Which issue is resolved by this Pull Request:
Resolves #620

/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@scylla-operator-bot scylla-operator-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 17, 2024
@tnozicka tnozicka force-pushed the split-probes branch 6 times, most recently from 99e202a to eff72c8 Compare May 20, 2024 13:07
@scylla-operator-bot scylla-operator-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2024
@scylla-operator-bot scylla-operator-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 21, 2024
@tnozicka tnozicka changed the title [WIP] Split probes Split ScyllaDB API status probes into a dedicated container May 21, 2024
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 21, 2024
@tnozicka tnozicka changed the title Split ScyllaDB API status probes into a dedicated container [WIP] Split ScyllaDB API status probes into a dedicated container May 22, 2024
@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 22, 2024
@tnozicka tnozicka changed the title [WIP] Split ScyllaDB API status probes into a dedicated container Split ScyllaDB API status probes into a dedicated container May 22, 2024
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 22, 2024
@tnozicka tnozicka mentioned this pull request May 22, 2024
Merged
2 tasks
@tnozicka
Copy link
Contributor Author

/cc @zimnx @rzetelskik

@scylla-operator-bot scylla-operator-bot bot requested review from rzetelskik and zimnx May 24, 2024 13:43
rzetelskik
rzetelskik reviewed May 27, 2024
View reviewed changes
@rzetelskik rzetelskik self-requested a review May 27, 2024 14:08
rzetelskik
rzetelskik approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@rzetelskik rzetelskik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
/assign zimnx

zimnx
zimnx approved these changes Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updates
/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tnozicka
Copy link
Contributor Author

https://github.com/scylladb/scylla-operator-release/issues/212
/retest

@scylla-operator-bot scylla-operator-bot bot merged commit ae4180f into scylladb:master Jun 10, 2024
12 checks passed
@tnozicka tnozicka deleted the split-probes branch June 10, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimnx zimnx zimnx approved these changes

@rzetelskik rzetelskik rzetelskik approved these changes

Assignees

@zimnx zimnx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split scylla probes into a separate container
3 participants
@tnozicka @zimnx @rzetelskik