-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release procedures #1871
Update release procedures #1871
Conversation
b0b0d72
to
c1cef98
Compare
#1028 (comment) |
/assign zimnx |
release.md
Outdated
git push upstream upstream/master:refs/heads/vX.Y | ||
``` | ||
### Mark `master` as the next release | ||
Moving `master` to the next release is done by creating a new `vX.Y+1.Z-alpha.0` tag for the next version. It can be either just the `git` tag or a proper `alpha` release, but given the very little difference the `beta` of the previous release, it's usability is limited to worth the effort. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Procedure should explain what we do, not leave the decision for someone who executes it. We either do alpha tags or not.
Moving `master` to the next release is done by creating a new `vX.Y+1.Z-alpha.0` tag for the next version. It can be either just the `git` tag or a proper `alpha` release, but given the very little difference the `beta` of the previous release, it's usability is limited to worth the effort. | |
Moving `master` to the next release is done by creating a new `vX.Y+1.Z-alpha.0` tag for the next version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
release.md
Outdated
1. Enable building docs from `vX.Y` branch by adding an entry to `docs/source/conf.py`. | ||
``` | ||
BRANCHES = ['master', 'v0.3', 'v1.0', 'v1.1', 'vX.Y'] | ||
BRANCHES = ['master', 'v1.11', 'v1.12', 'vX.Y'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BRANCHES = ['master', 'v1.11', 'v1.12', 'vX.Y'] | |
BRANCHES = ['master', 'vX.Y-2', 'vX.Y-1', 'vX.Y'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
release.md
Outdated
|
||
#### From a pre-release | ||
``` | ||
skopeo copy --all docker://quay.io/scylladb/scylla-operator:X.Y.0-rc.I docker://quay.io/scylladb/scylla-operator:X.Y.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skopeo copy --all docker://quay.io/scylladb/scylla-operator:X.Y.0-rc.I docker://quay.io/scylladb/scylla-operator:X.Y.0 | |
skopeo copy --all docker://quay.io/scylladb/scylla-operator:X.Y.Z-rc.I docker://quay.io/scylladb/scylla-operator:X.Y.Z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
release.md
Outdated
skopeo copy --all docker://quay.io/scylladb/scylla-operator:X.Y.0-rc.I docker://quay.io/scylladb/scylla-operator:X.Y.0 | ||
``` | ||
``` | ||
skopeo copy --all docker://quay.io/scylladb/scylla-operator:X.Y.0 docker://docker.io/scylladb/scylla-operator:X.Y.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skopeo copy --all docker://quay.io/scylladb/scylla-operator:X.Y.0 docker://docker.io/scylladb/scylla-operator:X.Y.0 | |
skopeo copy --all docker://quay.io/scylladb/scylla-operator:X.Y.Z docker://docker.io/scylladb/scylla-operator:X.Y.Z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
||
1. Submit a PR using `master` as target branch. | ||
### ScyllaDB User Slack | ||
Send a post to the `#scylla-operator` channel in ScyllaDB-Users Slack based on the following template. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO we should include notable changes paragraph as well, to promote what is important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems already included in the forum link - I've extended the description
- `#scylla-operator` channel in ScyllaDB-Users Slack | ||
- users mailing list (https://groups.google.com/g/scylladb-users) | ||
### Beta | ||
`beta` is a testing release that comes from a release branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't explain when it's tagged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
release.md
Outdated
Moving `master` to the next release is done by creating a new `vX.Y+1.Z-alpha.0` tag for the next version. It can be either just the `git` tag or a proper `alpha` release, but given the very little difference the `beta` of the previous release, it's usability is limited to worth the effort. | ||
``` | ||
git fetch [email protected]:scylladb/scylla-operator.git | ||
git tag -s -a vX.Y+1.Z-alpha.0 "${revision}" -m "vX.Y+1.Z-alpha.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
${revision}
is undefined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replaced
c1cef98
to
89e06a0
Compare
@tnozicka: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tnozicka, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
this is docs only |
@tnozicka: Overrode contexts on behalf of tnozicka: ci/prow/e2e-gke-parallel-clusterip In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description of your changes:
The PR brings up our release procedure to up to date with our recent infra changes and with how we've done it for v1.12.
The new procedure also no longer requires blocking
master
branch.