Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect related objects for ScyllaClusters and ScyllaDBMonitorings in must-gather #1855

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Collect related objects for ScyllaClusters and ScyllaDBMonitorings in must-gather #1855

merged 1 commit into from
Apr 19, 2024

Conversation

tnozicka
Copy link
Contributor

Description of your changes:
This PR adds support for collecting related resources for ScyllaClusters and ScyllaDBMonitorings. Because not all resources are connected through ownerReferences we dump the same namespace and don't filter the objects. Some examples of where ownerRefs wouldn't works are Services, Endpoints or other objects that don't have a direct relationship but affect say firewall rules (like NetworkPolicy). In the end, dumping all the objects in the same namespace seems like the best path.

Which issue is resolved by this Pull Request:
Resolves #1568

@tnozicka tnozicka added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 20, 2024
@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2024
@scylla-operator-bot scylla-operator-bot bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 20, 2024
@tnozicka tnozicka changed the title [WIP] Collect related objects for ScyllaClusters and ScyllaDBMonitorings in must-gather Collect related objects for ScyllaClusters and ScyllaDBMonitorings in must-gather Mar 20, 2024
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2024
@scylla-operator-bot scylla-operator-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2024
@tnozicka tnozicka force-pushed the must-gather-related-resources branch from 00d0a56 to 5c354ce Compare April 3, 2024 08:04
@scylla-operator-bot scylla-operator-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 3, 2024
@tnozicka
Copy link
Contributor Author

tnozicka commented Apr 3, 2024

#1694 (comment)
/retest

rzetelskik
rzetelskik reviewed Apr 17, 2024
View reviewed changes
Copy link
Member

@rzetelskik rzetelskik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two comments, rest lgtm

@rzetelskik rzetelskik self-requested a review April 18, 2024 08:32
rzetelskik
rzetelskik approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@rzetelskik rzetelskik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
/assign zimnx

zimnx
zimnx approved these changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tnozicka
Copy link
Contributor Author

tnozicka commented Apr 18, 2024 •
edited
Loading

#1900
(repair task wasn't deleted)
/retest

@tnozicka
Copy link
Contributor Author

master moved / images issue
/test images

@tnozicka
Copy link
Contributor Author

/retest

@tnozicka
Copy link
Contributor Author

same manager flake
/retest

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

scylla-operator-bot bot commented Apr 19, 2024 •
edited
Loading

@tnozicka: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-release-script-latest 00d0a56 link true /test e2e-gke-release-script-latest

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tnozicka
Copy link
Contributor Author

and once again #1694 (comment)
/retest

@scylla-operator-bot scylla-operator-bot bot merged commit 406fe93 into scylladb:master Apr 19, 2024
12 checks passed
@tnozicka tnozicka deleted the must-gather-related-resources branch April 19, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimnx zimnx zimnx approved these changes

@rzetelskik rzetelskik rzetelskik approved these changes

Assignees

@zimnx zimnx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Teach must-gather about related resources for scyllaclusters
3 participants
@tnozicka @zimnx @rzetelskik