Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate interval in manager task schedule spec #1853

Merged
merged 3 commits into from
May 6, 2024
Merged

Deprecate interval in manager task schedule spec #1853

merged 3 commits into from
May 6, 2024

Conversation

rzetelskik
Copy link
Member

@rzetelskik rzetelskik commented Mar 20, 2024 •
edited
Loading

Description of your changes: This PR deprecates the interval field in manager task schedule spec in favour of cron.

Which issue is resolved by this Pull Request:
Resolves #1796

/kind feature
/priority important-longterm
/hold for #1851

@scylla-operator-bot scylla-operator-bot bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 20, 2024
@scylla-operator-bot scylla-operator-bot bot requested review from tnozicka and zimnx March 20, 2024 10:34
@rzetelskik rzetelskik mentioned this pull request Mar 20, 2024
Merged
@rzetelskik rzetelskik changed the title Deprecate interval in manager task schedule spec [WIP] Deprecate interval in manager task schedule spec Mar 20, 2024
@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2024
@rzetelskik rzetelskik force-pushed the manager-deprecate-interval branch 4 times, most recently from c9ae0a0 to 804f6fc Compare March 21, 2024 16:49
@rzetelskik rzetelskik mentioned this pull request Mar 26, 2024
Merged
@rzetelskik rzetelskik marked this pull request as draft April 15, 2024 09:19
@scylla-operator-bot scylla-operator-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 15, 2024
@rzetelskik rzetelskik force-pushed the manager-deprecate-interval branch from 804f6fc to 5716414 Compare April 15, 2024 21:16
@scylla-operator-bot scylla-operator-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 15, 2024
@rzetelskik rzetelskik marked this pull request as ready for review April 15, 2024 21:17
@rzetelskik rzetelskik force-pushed the manager-deprecate-interval branch from 5716414 to 2b855d9 Compare April 15, 2024 21:33
@rzetelskik rzetelskik mentioned this pull request Apr 19, 2024
Closed
@rzetelskik rzetelskik changed the title [WIP] Deprecate interval in manager task schedule spec Deprecate interval in manager task schedule spec Apr 19, 2024
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 19, 2024
@rzetelskik rzetelskik force-pushed the manager-deprecate-interval branch from 2b855d9 to 9072ede Compare April 23, 2024 12:28
zimnx
zimnx approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
/assign tnozicka

@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2024
@rzetelskik
Copy link
Member Author

known manager flake
/test images
/retest

@rzetelskik rzetelskik requested a review from tnozicka May 6, 2024 10:45
tnozicka
tnozicka approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rzetelskik
Copy link
Member Author

thanks Tomas
/test images e2e-gke-parallel

@rzetelskik
Copy link
Member Author

/hold cancel

@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2024
@rzetelskik
Copy link
Member Author

@rzetelskik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-release-script-latest 804f6fc link true /test e2e-gke-release-script-latest
ci/prow/e2e-gke-parallel-clusterip 9072ede link unknown /test e2e-gke-parallel-clusterip
Full PR test history. Your PR dashboard.

known manager flake
/retest

@rzetelskik
Copy link
Member Author

@rzetelskik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-release-script-latest 804f6fc link true /test e2e-gke-release-script-latest
ci/prow/e2e-gke-parallel-clusterip 9072ede link true /test e2e-gke-parallel-clusterip
Full PR test history. Your PR dashboard.

same thing
/retest

@rzetelskik
Copy link
Member Author

@rzetelskik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-release-script-latest 804f6fc link true /test e2e-gke-release-script-latest
ci/prow/e2e-gke-parallel-clusterip 9072ede link true /test e2e-gke-parallel-clusterip

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

and again
/retest

@rzetelskik
Copy link
Member Author

@rzetelskik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-release-script-latest 804f6fc link true /test e2e-gke-release-script-latest
ci/prow/e2e-gke-parallel-clusterip 9072ede link true /test e2e-gke-parallel-clusterip
Full PR test history. Your PR dashboard.

again
/retest

@rzetelskik
Copy link
Member Author

@rzetelskik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-release-script-latest 804f6fc link true /test e2e-gke-release-script-latest
ci/prow/e2e-gke-parallel-clusterip 9072ede link true /test e2e-gke-parallel-clusterip
Full PR test history. Your PR dashboard.

/shrug
/retest

@scylla-operator-bot scylla-operator-bot bot added the ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ label May 6, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

scylla-operator-bot bot commented May 6, 2024 •
edited
Loading

@rzetelskik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gke-release-script-latest 804f6fc link true /test e2e-gke-release-script-latest

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rzetelskik
Copy link
Member Author

/retest

@scylla-operator-bot scylla-operator-bot bot merged commit 1941738 into scylladb:master May 6, 2024
13 checks passed
@rzetelskik rzetelskik deleted the manager-deprecate-interval branch May 6, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimnx zimnx zimnx approved these changes

@tnozicka tnozicka tnozicka approved these changes

Assignees

@tnozicka tnozicka

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate "interval" in ScyllaCluster's manager task API
3 participants
@rzetelskik @zimnx @tnozicka