Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Scheme Builder #1849

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Add Scheme Builder #1849

merged 1 commit into from
Mar 20, 2024

Conversation

zimnx
Copy link
Collaborator

@zimnx zimnx commented Mar 19, 2024 •
edited
Loading

It's useful when other project wants to add all types defined by Scylla Operator to its schema.

@zimnx zimnx added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 19, 2024
@scylla-operator-bot scylla-operator-bot bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 19, 2024
@zimnx
Add Scheme Builder
28af2b0 
It's useful when other project wants to add all types defined by
Scylla Operator to it's schema.
@zimnx zimnx force-pushed the mz/scheme-builder branch from cf790d3 to 28af2b0 Compare March 19, 2024 14:59
@zimnx
Copy link
Collaborator Author

zimnx commented Mar 19, 2024

slow schema change
/retest

tnozicka
tnozicka approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot merged commit 1520cf7 into scylladb:master Mar 20, 2024
11 of 12 checks passed
@zimnx zimnx added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/feature Categorizes issue or PR as related to a new feature. labels Jun 19, 2024
@zimnx zimnx deleted the mz/scheme-builder branch June 20, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnozicka tnozicka tnozicka approved these changes

@rzetelskik rzetelskik Awaiting requested review from rzetelskik

Assignees

@tnozicka tnozicka

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zimnx @tnozicka