Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect nodes in must-gather #1846

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Collect nodes in must-gather #1846

merged 1 commit into from
Apr 2, 2024

Conversation

tnozicka
Copy link
Contributor

@tnozicka tnozicka commented Mar 19, 2024 •
edited
Loading

Description of your changes:
Collection node objects in must-gather helps us to determine the OS, architecture, CRI and more.

Which issue is resolved by this Pull Request:
Resolves #1845

@tnozicka tnozicka added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 19, 2024
@scylla-operator-bot scylla-operator-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 19, 2024
@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2024
rzetelskik
rzetelskik reviewed Mar 19, 2024
View reviewed changes
Copy link
Member

@rzetelskik rzetelskik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit tests need updating, otherwise lgtm
/assign zimnx

@tnozicka tnozicka changed the title Collect nodes in must-gather [WIP] Collect nodes in must-gather Mar 19, 2024
@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2024
@tnozicka tnozicka force-pushed the must-gatehr-nodes branch from ae86219 to a6cb4e6 Compare March 19, 2024 14:42
@tnozicka tnozicka changed the title [WIP] Collect nodes in must-gather Collect nodes in must-gather Mar 19, 2024
@scylla-operator-bot scylla-operator-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 19, 2024
@tnozicka
Copy link
Contributor Author

/retest
#1694 (comment)

@tnozicka
Copy link
Contributor Author

disks
/retest

@tnozicka
Copy link
Contributor Author

/test images

@tnozicka
Copy link
Contributor Author

/retest

zimnx
zimnx approved these changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rzetelskik
Copy link
Member

/override ci/prow/e2e-gke-release-script-latest
shouldn't have been triggered

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

@rzetelskik: rzetelskik unauthorized: /override is restricted to Repo administrators.

In response to this:

/override ci/prow/e2e-gke-release-script-latest
shouldn't have been triggered

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rzetelskik
Copy link
Member

@tnozicka could you override ci/prow/e2e-gke-release-script-latest?

@tnozicka
Copy link
Contributor Author

tnozicka commented Apr 2, 2024

/override ci/prow/e2e-gke-release-script-latest

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

@tnozicka: Overrode contexts on behalf of tnozicka: ci/prow/e2e-gke-release-script-latest

In response to this:

/override ci/prow/e2e-gke-release-script-latest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@scylla-operator-bot scylla-operator-bot bot merged commit 46ad46d into scylladb:master Apr 2, 2024
13 checks passed
@tnozicka tnozicka deleted the must-gatehr-nodes branch April 2, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzetelskik rzetelskik rzetelskik left review comments

@zimnx zimnx zimnx approved these changes

Assignees

@zimnx zimnx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Must-gather should collect Node objects
3 participants
@tnozicka @rzetelskik @zimnx