Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cert-manager example to v1.14.4 #1836

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Update cert-manager example to v1.14.4 #1836

merged 1 commit into from
Mar 18, 2024

Conversation

tnozicka
Copy link
Contributor

@tnozicka tnozicka commented Mar 15, 2024 •
edited
Loading

Description of your changes:
Updates the cert-manager example to v1.14.4.

Source https://github.com/cert-manager/cert-manager/releases/download/v1.14.0/cert-manager.yaml

@tnozicka tnozicka added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 15, 2024
@scylla-operator-bot scylla-operator-bot bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 15, 2024
rzetelskik
rzetelskik reviewed Mar 15, 2024
View reviewed changes
Copy link
Member

@rzetelskik rzetelskik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tnozicka can you verify you sent all the changes you wanted? It shows up as a deletion and nothing more to me

@tnozicka
Copy link
Contributor Author

tnozicka commented Mar 15, 2024 •
edited
Loading

@tnozicka can you verify you sent all the changes you wanted? It shows up as a deletion and nothing more to me

ci is about to find out (some deletions are old crd versions) but I see +2,686 −14,007

@rzetelskik
Copy link
Member

I guess it's just github diff being weird then.
image
The CI works and the manifest looks sane, so lgtm.
/assign zimnx

@tnozicka
Copy link
Contributor Author

#1028 (comment)
/retest

@zimnx
Copy link
Collaborator

zimnx commented Mar 15, 2024

/approve
/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tnozicka
Copy link
Contributor Author

#1767 (comment)
/retest

@scylla-operator-bot scylla-operator-bot bot merged commit 5f5bfca into scylladb:master Mar 18, 2024
12 checks passed
@tnozicka tnozicka deleted the update-cert-manager branch March 18, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzetelskik rzetelskik rzetelskik left review comments

@zimnx zimnx Awaiting requested review from zimnx

Assignees

@zimnx zimnx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tnozicka @rzetelskik @zimnx