Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TLS disablement note from restore docs #1831

Merged

Conversation

rzetelskik
Copy link
Member

Description of your changes: #1674 was merged, so with Scylla Manager 3.2.6, the users no longer need to disable AutomaticTLSCertificates for the restore procedure to work. This PR removes the note asking the users to disable it from the restore procedure doc.

Which issue is resolved by this Pull Request:
Resolves #1830

/kind documentation
/priority important-longterm
/hold to be tested manually, preferably together with a 5.4 workaround

@scylla-operator-bot scylla-operator-bot bot added kind/documentation Categorizes issue or PR as related to documentation. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 14, 2024
@scylla-operator-bot scylla-operator-bot bot requested review from tnozicka and zimnx March 14, 2024 10:07
@scylla-operator-bot scylla-operator-bot bot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 14, 2024
@rzetelskik
Copy link
Member Author

/hold cancel

@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2024
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @tnozicka

@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2024
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot merged commit 9c030ac into scylladb:master Mar 14, 2024
9 checks passed
@rzetelskik rzetelskik deleted the restore-doc-remove-caution branch March 14, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove TLS disablement note from restore docs
3 participants