Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Scylla Manager E2E test with repair task update and deletion #1823

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Extend Scylla Manager E2E test with repair task update and deletion #1823

merged 1 commit into from
Mar 15, 2024

Conversation

rzetelskik
Copy link
Member

@rzetelskik rzetelskik commented Mar 12, 2024 •
edited
Loading

Description of your changes: This PR extends the existing manager integration E2E test with update and deletion of the repair task to increase coverage of tested operations.

Which issue is resolved by this Pull Request:
Resolves #

/kind feature
/priority important-longterm
/cc

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

@rzetelskik: GitHub didn't allow me to request PR reviews from the following users: rzetelskik.

Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Description of your changes: WIP

Which issue is resolved by this Pull Request:
Resolves #

/kind feature
/priority important-longterm
/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@scylla-operator-bot scylla-operator-bot bot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 12, 2024
@rzetelskik rzetelskik force-pushed the manager-repair-e2e-update branch 2 times, most recently from 7dc5716 to d1083c1 Compare March 13, 2024 12:32
@rzetelskik rzetelskik changed the title [WIP] Extend Scylla Manager E2E test with repair task update Extend Scylla Manager E2E test with repair task update and deletion Mar 14, 2024
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 14, 2024
@rzetelskik
Copy link
Member Author

both flakes seem related to PDs
/retest

@rzetelskik
Copy link
Member Author

/cc zimnx tnozicka

@scylla-operator-bot scylla-operator-bot bot requested review from tnozicka and zimnx March 14, 2024 13:17
@rzetelskik
Copy link
Member Author

seems related to PDs again
/retest

@rzetelskik
Copy link
Member Author

/test images
/retest

@rzetelskik
Copy link
Member Author

timeouts again
/test images
/retest

tnozicka
tnozicka reviewed Mar 15, 2024
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2024
zimnx
zimnx approved these changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @tnozicka

@rzetelskik rzetelskik force-pushed the manager-repair-e2e-update branch 2 times, most recently from 67b174a to 9c688ea Compare March 15, 2024 10:50
@rzetelskik rzetelskik force-pushed the manager-repair-e2e-update branch from 9c688ea to 4a57b38 Compare March 15, 2024 11:49
@rzetelskik rzetelskik requested a review from tnozicka March 15, 2024 14:32
tnozicka
tnozicka approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
/assign @zimnx

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zimnx
Copy link
Collaborator

zimnx commented Mar 15, 2024

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2024
@scylla-operator-bot scylla-operator-bot bot merged commit f356138 into scylladb:master Mar 15, 2024
11 of 12 checks passed
@rzetelskik rzetelskik deleted the manager-repair-e2e-update branch March 15, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimnx zimnx zimnx approved these changes

@tnozicka tnozicka tnozicka approved these changes

Assignees

@zimnx zimnx

@tnozicka tnozicka

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rzetelskik @zimnx @tnozicka