Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass auth token on Scylla Manager cluster update #1800

Merged

Conversation

rzetelskik
Copy link
Member

Description of your changes: There is a bug in our Scylla Manager integration where the controller checks for auth token mismatch and issues an update request to Scylla Manager, but it doesn't set said auth token parameter. This PR sets the auth token parameter.

Which issue is resolved by this Pull Request:
Resolves #1799

/kind bug
/priority important-longterm
/cc zimnx

@scylla-operator-bot scylla-operator-bot bot requested a review from zimnx March 7, 2024 13:58
@scylla-operator-bot scylla-operator-bot bot added kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 7, 2024
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!
/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2024
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2024
@scylla-operator-bot scylla-operator-bot bot merged commit 7f80afe into scylladb:master Mar 7, 2024
12 checks passed
@tnozicka
Copy link
Contributor

tnozicka commented Mar 7, 2024

@rzetelskik what the fallout from this? do we need it in v1.12? how did it work without the token?

@rzetelskik rzetelskik deleted the manager-auth-token-fix branch March 7, 2024 15:16
@rzetelskik
Copy link
Member Author

what the fallout from this?

In theory that could cause the controller to keep sending update requests to the manager server

do we need it in v1.12? how did it work without the token?

It didn't, but I suppose you'd only hit it if you lost the secret or manually deleted it. In that case you could manually fix it by deleting the cluster from manager and letting the controller sync again. It's better to backport it imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scylla Manager integration does not pass auth token on cluster update despite auth token mismatch
3 participants