Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Scylla Manager E2E test with progress check #1784

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Extend Scylla Manager E2E test with progress check #1784

merged 1 commit into from
Mar 5, 2024

Conversation

rzetelskik
Copy link
Member

@rzetelskik rzetelskik commented Mar 1, 2024 •
edited
Loading

Description of your changes:
At this point the E2E for Scylla Manager integration only tests that the task was scheduled. This PR extends the test with awaiting for task's completeness.

Which issue is resolved by this Pull Request:
Part of the effort to improve scylla manager integration.

/kind feature
/priority important-longterm
/cc

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

@rzetelskik: GitHub didn't allow me to request PR reviews from the following users: rzetelskik.

Note that only scylladb members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Description of your changes: WIP

Which issue is resolved by this Pull Request:
Resolves #

/kind feature
/priority important-longterm
/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@scylla-operator-bot scylla-operator-bot bot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 1, 2024
@rzetelskik rzetelskik changed the title Extend Scylla Manager E2E test with progress check [WIP] Extend Scylla Manager E2E test with progress check Mar 1, 2024
@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 1, 2024
@rzetelskik rzetelskik force-pushed the extend-manager-e2e branch from 95761dc to 79cb5ee Compare March 1, 2024 12:27
@rzetelskik rzetelskik changed the title [WIP] Extend Scylla Manager E2E test with progress check Extend Scylla Manager E2E test with progress check Mar 1, 2024
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 1, 2024
@rzetelskik rzetelskik requested review from zimnx and tnozicka March 1, 2024 14:15
@rzetelskik rzetelskik force-pushed the extend-manager-e2e branch from 79cb5ee to 837f579 Compare March 1, 2024 14:31
tnozicka
tnozicka approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/asssing @zimnx

@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
@rzetelskik rzetelskik force-pushed the extend-manager-e2e branch from 837f579 to e2ab34d Compare March 5, 2024 10:51
zimnx
zimnx approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rzetelskik, tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rzetelskik
Copy link
Member Author

flake #1525 (comment)
/retest

@scylla-operator-bot scylla-operator-bot bot merged commit f2ff62d into scylladb:master Mar 5, 2024
12 checks passed
@rzetelskik rzetelskik deleted the extend-manager-e2e branch March 7, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnozicka tnozicka tnozicka approved these changes

@zimnx zimnx zimnx approved these changes

Assignees

@zimnx zimnx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rzetelskik @zimnx @tnozicka