Return empty list of loop devices when losetup doesn't print anything
#1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimnx
added
kind/bug
scylla-operator-bot
bot
added
the
size/L
scylla-operator-bot
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tnozicka, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Version of `losetup` installed on EKS has different behavior when there are no loop devices on the node. On GKE and local env, it returns an empty list of loop devices as json output, where on EKS it doesn't print anything, even though we ask for json explicitly. Losetup library now supports both behaviors.
zimnx
force-pushed
the
mz/fix-losetup-prinitng-nothing
branch
from
fbafbf9 to
77ee77c
Compare
|
Flake - #1426 (comment) |
scylla-operator-bot
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version of
losetupinstalled on EKS has different behavior when there are no loop devices on the node. On GKE and local env, it returns an empty list of loop devices as json output, where on EKS it doesn't print anything, even though we ask for json explicitly.Losetup library now supports both behaviors.
Fixes #1775