Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grafana permissions for kubectl cp and run it as non root #1475

Merged
merged 1 commit into from
May 27, 2024
Merged

Fix grafana permissions for kubectl cp and run it as non root #1475

merged 1 commit into from
May 27, 2024

Conversation

tnozicka
Copy link
Contributor

kubectl cp was hitting permission denied, this PR fixes it + Grafana permissions are scaled down.

@tnozicka tnozicka added kind/bug Categorizes issue or PR as related to a bug. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Oct 13, 2023
@scylla-operator-bot scylla-operator-bot bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 13, 2023
@tnozicka
Copy link
Contributor Author

tnozicka commented Jan 2, 2024

/retest

zimnx
zimnx approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tnozicka
Copy link
Contributor Author

tnozicka commented May 7, 2024

/override ci/prow/e2e-gke-release-script-latest

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

@tnozicka: Overrode contexts on behalf of tnozicka: ci/prow/e2e-gke-release-script-latest

In response to this:

/override ci/prow/e2e-gke-release-script-latest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tnozicka
Copy link
Contributor Author

tnozicka commented May 7, 2024

#1694 (comment)
/retest

@tnozicka
Copy link
Contributor Author

tnozicka commented May 7, 2024

/retest

rzetelskik
rzetelskik reviewed May 27, 2024
View reviewed changes
Copy link
Member

@rzetelskik rzetelskik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

manager flake in the most recent run, outdated
/retest

@tnozicka
Copy link
Contributor Author

/test images

@tnozicka
Copy link
Contributor Author

/retest

@tnozicka
Copy link
Contributor Author

/override ci/prow/e2e-gke-release-script-latest
(PR is pending to fix the script)

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

@tnozicka: Overrode contexts on behalf of tnozicka: ci/prow/e2e-gke-release-script-latest

In response to this:

/override ci/prow/e2e-gke-release-script-latest
(PR is pending to fix the script)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@scylla-operator-bot scylla-operator-bot bot merged commit b535904 into scylladb:master May 27, 2024
12 of 13 checks passed
@tnozicka tnozicka deleted the fix-grafana-perms branch May 27, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzetelskik rzetelskik rzetelskik left review comments

@zimnx zimnx zimnx approved these changes

Assignees

@zimnx zimnx

@rzetelskik rzetelskik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tnozicka @zimnx @rzetelskik