Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: stable redirection broke branch links #350

Closed
zimnx opened this issue Jan 28, 2021 · 4 comments · Fixed by #353 or #374
Closed

docs: stable redirection broke branch links #350

zimnx opened this issue Jan 28, 2021 · 4 comments · Fixed by #353 or #374
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@zimnx
Copy link
Collaborator

zimnx commented Jan 28, 2021

Links which were used in Release Notes, and other user facing communication doesn't work after #342

These two should be redirected to the same content (at this moment), but first one returns 404
https://operator.docs.scylladb.com/v1.0/migration.html
https://operator.docs.scylladb.com/stable/migration.html

We cannot use stable links in release notes, because once tag is changed, old release notes will use new documentation page.
@zimnx zimnx added the kind/bug Categorizes issue or PR as related to a bug. label Jan 28, 2021
@zimnx
Copy link
Collaborator Author

zimnx commented Jan 28, 2021 •
edited
Loading

@dgarcia360 @tzach

@zimnx zimnx mentioned this issue Jan 28, 2021
Merged
@zimnx
Copy link
Collaborator Author

zimnx commented Jan 28, 2021 •
edited
Loading

@dgarcia360 I reverted #342, please resend patch once this issue is solved.

@zimnx
Copy link
Collaborator Author

zimnx commented Jan 28, 2021

Note: Because live version already has revert of #342, situation from issue description is opposite. But with #342 v1.0 leads to 404, stable leads to v1.0 documentation.

This was referenced Jan 28, 2021
Merged
Closed
Merged
@dgarcia360
Copy link
Contributor

Thanks @zimnx , I've updated the sphinx-multiversion.
I've submitted again the same PR: #353

@zimnx zimnx closed this as completed in #353 Feb 1, 2021
zimnx added a commit that referenced this issue Feb 9, 2021
@zimnx
replace: retry on conflict during removal of PVC finalizers (#350)
4ac9be3 
Operator updates PVC which is subject for removal, so this is expected
that update may conflict.
Retry should reduce the race window with StatefulSet controller

Fixes #350
zimnx added a commit that referenced this issue Feb 9, 2021
@zimnx
replace: retry on conflict during removal of PVC finalizers (#350)
9c735de 
Operator updates PVC which is subject for removal, so this is expected
that update may conflict.
Retry should reduce the race window with StatefulSet controller

Fixes #350
@zimnx zimnx mentioned this issue Feb 9, 2021
Merged
zimnx added a commit that referenced this issue Feb 12, 2021
@zimnx
replace: use Patch() to clear PVC finalizers (#350)
5862e8e 
Operator updates PVC which is subject for removal, so this is expected
that update may conflict.
To avoid conflicts instead updating whole resource, patch is used.

Fixes #350
zimnx added a commit that referenced this issue Feb 12, 2021
@zimnx
replace: use Patch() to clear PVC finalizers (#350)
db0774b 
Operator updates PVC which is subject for removal, so this is expected
that update may conflict.
To avoid conflicts instead updating whole resource, patch is used.

Fixes #350
zimnx added a commit that referenced this issue Feb 12, 2021
@zimnx
replace: use Patch() to clear PVC finalizers (#350)
ce54895 
Operator updates PVC which is subject for removal, so this is expected
that update may conflict.
To avoid conflicts instead updating whole resource, patch is used.

Fixes #350
zimnx added a commit that referenced this issue Feb 12, 2021
@zimnx
replace: eliminate conflict during cleanup of PVC finalizers (#350)
f434408 
Operator updated PVC which is subject for removal, so this is expected
that update may conflict.
To avoid conflicts instead updating whole resource, patch is used.

Fixes #350
zimnx added a commit that referenced this issue Feb 12, 2021
@zimnx
replace: eliminate conflict during cleanup of PVC finalizers (#350)
bedaa73 
Operator updated PVC which is subject for removal, so this is expected
that update may conflict.
To avoid conflicts instead updating whole resource, patch is used.

Fixes #350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
2 participants
@zimnx @dgarcia360