Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScyllaConfigAgent secret name is ignored #298

Closed
zimnx opened this issue Dec 15, 2020 · 1 comment · Fixed by #301
Closed

ScyllaConfigAgent secret name is ignored #298

zimnx opened this issue Dec 15, 2020 · 1 comment · Fixed by #301
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@zimnx
Copy link
Collaborator

zimnx commented Dec 15, 2020

Describe the bug

Value of ScyllaConfigAgent from CRD is ignored, and hardcoded value is passed to as a VolumeSource:

scylla-operator/pkg/controllers/cluster/resource/resource.go

Line 171 in 629e325

SecretName: "scylla-agent-config-secret",

@zimnx zimnx added the kind/bug Categorizes issue or PR as related to a bug. label Dec 15, 2020
@zimnx zimnx added this to the 1.0 milestone Dec 15, 2020
zimnx added a commit that referenced this issue Dec 15, 2020
@zimnx
cluster: take agent secret name from rack spec (#298)
f5a6599 
Fixes #298
@zimnx zimnx mentioned this issue Dec 15, 2020
Merged
1 task
zimnx added a commit that referenced this issue Dec 16, 2020
@zimnx
cluster: take agent secret name from rack spec (#298)
b8ac59a 
Fixes #298
@flecno
Copy link

flecno commented Dec 16, 2020

It also ignores the field ScyllaConfig/scylla-client-config-secret

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cluster: take agent secret name from rack spec (#298) scylladb/scylla-operator
2 participants
@flecno @zimnx