Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for service monitors' custom labels in Scylla Helm chart #1194

Closed
Kavinraja-G opened this issue Mar 27, 2023 · 6 comments · Fixed by #2037
Closed

Add support for service monitors' custom labels in Scylla Helm chart #1194

Kavinraja-G opened this issue Mar 27, 2023 · 6 comments · Fixed by #2037
Labels
kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@Kavinraja-G
Copy link
Contributor

Is this a bug report or feature request?

  • Feature Request

What should the feature do:
Allow passing custom labels for serviceMonitors (both scylla manager & scylla cluster) through helm values.

What is use case behind this feature:
This is useful when the users have their own custom Prometheus setup with serviceMonitorSelector matchLabels are configured.

Additional Information:
Nil
@scylla-operator-bot
Copy link
Collaborator

The Scylla Operator project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 30d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out

/lifecycle stale

1 similar comment
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

The Scylla Operator project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 30d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out

/lifecycle stale

@scylla-operator-bot scylla-operator-bot bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 23, 2024
@TessaIO TessaIO mentioned this issue Jul 26, 2024
Merged
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

The Scylla Operator project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 30d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out

/lifecycle rotten

@scylla-operator-bot scylla-operator-bot bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 23, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

The Scylla Operator project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 30d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out

/close not-planned

@scylla-operator-bot scylla-operator-bot bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 22, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

@scylla-operator-bot[bot]: Closing this issue, marking it as "Not Planned".

In response to this:

The Scylla Operator project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 30d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

TessaIO added a commit to TessaIO/scylla-operator that referenced this issue Oct 28, 2024
@TessaIO
helm: support custom labels for service monitors - fixes scylladb#1194
81eb656 
Signed-off-by: ahmed.g <[email protected]>
Signed-off-by: TessaIO <[email protected]>
TessaIO added a commit to TessaIO/scylla-operator that referenced this issue Oct 28, 2024
@TessaIO
helm: support custom labels for service monitors - fixes scylladb#1194
08f1a29 
Signed-off-by: ahmed.g <[email protected]>
Signed-off-by: TessaIO <[email protected]>
@rzetelskik rzetelskik reopened this Oct 28, 2024
@scylla-operator-bot scylla-operator-bot bot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Oct 28, 2024
@rzetelskik rzetelskik changed the title Allow custom labels for ServiceMonitors Add support for service monitors' custom labels in Scylla Helm chart Oct 28, 2024
@rzetelskik
Copy link
Member

rzetelskik commented Oct 28, 2024 •
edited
Loading

/triage accepted
/kind machinery
/priority important-longterm

@scylla-operator-bot scylla-operator-bot bot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 28, 2024
@rzetelskik rzetelskik removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for service monitors' custom labels in Scylla Helm chart TessaIO/scylla-operator
3 participants
@rzetelskik @Kavinraja-G @scylla-operator-bot