Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add poetry 1.8 image #69

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Add poetry 1.8 image #69

merged 1 commit into from
Sep 30, 2024

Conversation

rzetelskik
Copy link
Member

@rzetelskik rzetelskik commented Sep 30, 2024 •
edited
Loading

This PR adds an image with poetry 1.8.

Required due to a dependency bump in scylladb/scylla-operator#2132.

@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@scylla-operator-bot scylla-operator-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2024
@scylla-operator-bot scylla-operator-bot bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 30, 2024
@rzetelskik rzetelskik added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 30, 2024
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Sep 30, 2024
@rzetelskik rzetelskik added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Sep 30, 2024
@scylla-operator-bot scylla-operator-bot bot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Sep 30, 2024
@rzetelskik rzetelskik changed the title [WIP] Add poetry 1.8 image Add poetry 1.8 image Sep 30, 2024
@rzetelskik rzetelskik marked this pull request as ready for review September 30, 2024 11:25
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2024
zimnx
zimnx reviewed Sep 30, 2024
View reviewed changes
@rzetelskik rzetelskik requested a review from zimnx September 30, 2024 11:48
zimnx
zimnx approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
/assign tnozicka

zimnx
zimnx approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2024
@zimnx zimnx added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2024
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: rzetelskik, zimnx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2024
@zimnx
Copy link
Collaborator

zimnx commented Sep 30, 2024

/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2024
@scylla-operator-bot scylla-operator-bot bot merged commit be4ee50 into scylladb:master Sep 30, 2024
2 checks passed
@rzetelskik rzetelskik deleted the poetry-1.8 branch September 30, 2024 14:38
tnozicka
tnozicka reviewed Oct 2, 2024
View reviewed changes
image-spec.csv
@@ -5,4 +5,5 @@ context_dir,image_tag,from_tag
./kube-tools/latest,kube-tools,
./node-setup,node-setup,base-ubi-9.4-minimal
./poetry/1.5,poetry-1.5,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we still building 1.5?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll send a separate PR to remove it, I didn't want to do it before all the jobs started passing with 1.8

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thx - btw. the old 1.5 image would still be there, it would just not receive updates, so this may not need a 2 step process next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnozicka tnozicka tnozicka left review comments

@zimnx zimnx zimnx approved these changes

Assignees

@zimnx zimnx

@tnozicka tnozicka

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rzetelskik @zimnx @tnozicka