Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scylla-detailed: compression panels, remove raw and make the title clearer #2395

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

amnonh
Copy link
Collaborator

@amnonh amnonh commented Sep 12, 2024

After the change, add ratio, and show only sent information
image

Fixes #2392

@amnonh
Copy link
Collaborator Author

amnonh commented Sep 16, 2024

@michoecho following comment from @mykaul do we need both send and receive? It should be the same, so maybe we can show just one of them

@michoecho
Copy link
Contributor

@michoecho following comment from @mykaul do we need both send and receive? It should be the same, so maybe we can show just one of them

The contents of the dashboard should be dictated by its purpose.

If the purpose is to show the compression ratio, or the overall throughput of RPC network traffic in the cluster, then showing "send" alone is good enough, because "receive" should — in total — have the same information.
If the purpose is to be yet another data point for debugging performance issues, then send and receive are different, and should be both displayed.

@mykaul
Copy link
Contributor

mykaul commented Sep 16, 2024

@michoecho following comment from @mykaul do we need both send and receive? It should be the same, so maybe we can show just one of them

The contents of the dashboard should be dictated by its purpose.

If the purpose is to show the compression ratio, or the overall throughput of RPC network traffic in the cluster, then showing "send" alone is good enough, because "receive" should — in total — have the same information. If the purpose is to be yet another data point for debugging performance issues, then send and receive are different, and should be both displayed.

For debugging we have the Prometheus interface, if we need to query both, IMHO.

@amnonh amnonh force-pushed the compression_comments branch from 479fa52 to 2c59ec5 Compare September 18, 2024 11:45
@amnonh amnonh merged commit 3238ccb into scylladb:master Sep 18, 2024
@amnonh amnonh deleted the compression_comments branch September 18, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compression related panels - nits
3 participants